chore(deps): migrate to community @faker-js/faker #30098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This comment was marked as resolved.
This comment was marked as resolved.
MikeMcC399
force-pushed
the
migrate/faker-community-version
branch
from
57e40ff
to
5153340
Compare
MikeMcC399
force-pushed
the
migrate/faker-community-version
branch
from
7e1e07c
to
3c4bf63
Compare
MikeMcC399
force-pushed
the
migrate/faker-community-version
branch
from
3c4bf63
to
3ba76b4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
@MikeMcC399 Great! I'll kick off the tests. |
MikeMcC399
force-pushed
the
migrate/faker-community-version
branch
from
3ba76b4
to
1eaedae
Compare
|
Thanks for picking out the failures! I reverted the tree-shaking syntax for importing faker which it seems is only good for The following tests all pass when run locally: yarn workspace @packages/frontend-shared cypress:run:ct
yarn workspace @packages/frontend-shared cypress:run:ct --browser chrome
yarn workspace @packages/frontend-shared check-ts
yarn workspace @packages/app check-ts |
jennifer-shehane
approved these changes
Aug 26, 2024
cacieprins
approved these changes
Aug 26, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fakerto supported version #30096Additional details
The deprecated npm module [email protected] is migrated to the identical (non-deprecated) community version @faker-js/[email protected]. See note in https://v6.fakerjs.dev/migration-guide-v5/
For background information read also I heard something happened. What's the TLDR?.
Steps to test
How has the user experience changed?
No change.
PR Tasks
cypress-documentation?type definitions?